Skip to content

Fix GH-14637: memory leak after failed heap allocation due to mem limit. #14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen marked this pull request as ready for review June 23, 2024 19:47
@devnexen devnexen requested a review from nielsdos as a code owner June 23, 2024 19:47
@nielsdos
Copy link
Member

nielsdos commented Jun 23, 2024

This change is right, but doesn't solve the fundamental problem, e.g. slightly modifying the script makes you hit the problem again in a different way.
GH-14637 is actually a duplicate of #14044, and I think it should be closed as such.
This PR may be merged however (if you clean up the comments) because it's a nice optimization on its own.

@devnexen
Copy link
Member Author

oh I am far to understand the whole extension :)

@devnexen devnexen merged commit 8eb0889 into php:master Jun 23, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants